Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(soffit-pwa): new version with i18n, content loader, form submit signal #769

Merged
merged 41 commits into from
Feb 6, 2023

Conversation

njfamirm
Copy link
Member

@njfamirm njfamirm commented Feb 5, 2023

No description provided.

@njfamirm njfamirm added the new-feature New features or options. label Feb 5, 2023
@njfamirm njfamirm added this to the v0.x milestone Feb 5, 2023
@njfamirm njfamirm self-assigned this Feb 5, 2023
@njfamirm njfamirm requested a review from alimd as a code owner February 5, 2023 17:39
// icon: 'logo-microsoft',
headline: 'Soffit Trading',
content: html`
Soffit started producing plaster products with the aim of optimizing the construction and also reducing the cost of supply and maintenance of the building in the long term.<br/>

Check failure

Code scanning / ESLint

Enforce a maximum line length

This line has a length of 183. Maximum allowed is 120.
headline: 'Soffit Trading',
content: html`
Soffit started producing plaster products with the aim of optimizing the construction and also reducing the cost of supply and maintenance of the building in the long term.<br/>
Also, according to the expansion of the market and the needs of customers, it has increased the variety of designs and materials of its products.

Check failure

Code scanning / ESLint

Enforce a maximum line length

This line has a length of 151. Maximum allowed is 120.
content: html`
Soffit started producing plaster products with the aim of optimizing the construction and also reducing the cost of supply and maintenance of the building in the long term.<br/>
Also, according to the expansion of the market and the needs of customers, it has increased the variety of designs and materials of its products.
Among the advantages of Soffit roofs, we can mention high speed of implementation, insulation of sound, humidity and heat. It can also be mentioned the ease of access to the facilities.<br/>

Check failure

Code scanning / ESLint

Enforce a maximum line length

This line has a length of 196. Maximum allowed is 120.
Soffit started producing plaster products with the aim of optimizing the construction and also reducing the cost of supply and maintenance of the building in the long term.<br/>
Also, according to the expansion of the market and the needs of customers, it has increased the variety of designs and materials of its products.
Among the advantages of Soffit roofs, we can mention high speed of implementation, insulation of sound, humidity and heat. It can also be mentioned the ease of access to the facilities.<br/>
Soffit intends to increase its share in the use of renewable raw materials in production to preserve the environment for future generations.

Check failure

Code scanning / ESLint

Enforce a maximum line length

This line has a length of 146. Maximum allowed is 120.
@alimd alimd changed the title feat(soffit-pwa): i18n, content loader, form submit signal feat(soffit-pwa): new version with i18n, content loader, form submit signal Feb 6, 2023
@alimd alimd merged commit 30b57ba into next Feb 6, 2023
@alimd alimd deleted the feat/soffit-i18n branch February 6, 2023 18:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants